Re: patch (for 9.1) string functions - Mailing list pgsql-hackers

From Itagaki Takahiro
Subject Re: patch (for 9.1) string functions
Date
Msg-id AANLkTimuv9Rxu1cRQwQa4pO4Av9kAIwUrW-LzQ8IlZrf@mail.gmail.com
Whole thread Raw
In response to Re: patch (for 9.1) string functions  (Pavel Stehule <pavel.stehule@gmail.com>)
Responses Re: patch (for 9.1) string functions
List pgsql-hackers
I reviewed the core changes of the patch. I don't think we need
mb_string_info() at all. Instead, we can just call pg_mbxxx() functions.

I rewrote the patch to use pg_mbstrlen_with_len() and pg_mbcharcliplen().
What do you think the changes? It requires re-counting lengths of multi-byte
strings in some cases, but the code will be much simpler and can avoid
allocating length buffers.

I'd like to apply contrib/stringinfo apart from the core changes,
because there seems to be still some idea to improve sprintf().

--
Itagaki Takahiro

Attachment

pgsql-hackers by date:

Previous
From: Fujii Masao
Date:
Subject: Fwd: Streaming Replication: Checkpoint_segment and wal_keep_segments on standby
Next
From: Itagaki Takahiro
Date:
Subject: Re: patch: to_string, to_array functions