Re: pg_stat_transaction patch - Mailing list pgsql-hackers

From Itagaki Takahiro
Subject Re: pg_stat_transaction patch
Date
Msg-id AANLkTimjcCUvTjtVK12cRZElto9nR1ukdg5p7MUdLBsO@mail.gmail.com
Whole thread Raw
In response to pg_stat_transaction patch  (Joel Jacobson <joel@gluefinance.com>)
Responses Re: pg_stat_transaction patch
Re: pg_stat_transaction patch
Re: pg_stat_transaction patch
List pgsql-hackers
"Accessor functions to get so far collected statistics for the current
transaction"
https://commitfest.postgresql.org/action/patch_view?id=301

The latest version of the patch works as expected, and also well-formed.
I'll mark the patch to "Ready for Committer".
http://archives.postgresql.org/message-id/AANLkTikSYdRwATGAP5U6O6zwIO4b_WNJXIbUd2y2tI01@mail.gmail.com

The added views and functions only accumulates activity counters
in the same transaction where the stat views are queried. So we
need to check the view before COMMIT or ROLLBACK.

The only issue in the patch is too long view and function names: - pg_stat_transaction_user_tables (31 chars) -
pg_stat_get_transaction_tuples_hot_updated(42 chars) - pg_stat_get_transaction_function_self_time (42 chars)
 

Since we've already used _xact_ in some system objects, we could replace
_transaction_ parts with _xact_. It will save 7 key types per query ;-)

-- 
Itagaki Takahiro


pgsql-hackers by date:

Previous
From: Pavel Stehule
Date:
Subject: Re: patch (for 9.1) string functions
Next
From: Magnus Hagander
Date:
Subject: Re: pg_stat_transaction patch