Re: Issue with libpq < 8.4 - Mailing list pgadmin-hackers

From Magnus Hagander
Subject Re: Issue with libpq < 8.4
Date
Msg-id AANLkTimUnU3kihaSO8oqGN4Gj3=FR9HfjzyYsjTC1wa6@mail.gmail.com
Whole thread Raw
In response to Re: Issue with libpq < 8.4  (Dave Page <dpage@pgadmin.org>)
Responses Re: Issue with libpq < 8.4  (Dave Page <dpage@pgadmin.org>)
List pgadmin-hackers
On Tue, Aug 24, 2010 at 12:28 PM, Dave Page <dpage@pgadmin.org> wrote:
> On Tue, Aug 24, 2010 at 11:01 AM, Guillaume Lelarge
> <guillaume@lelarge.info> wrote:
>> Adding a configure check doesn't seem that simple to me :)
>
> If you can wrangle wxWidgets sizers, you can surely cope with a
> configure check :-)
>
> FYI, all the interesting stuff is in acinclude.m4. The bits that are
> called, and in what order comes from configure.ac.in.
>
>> I suppose it'll fix packagers issue. I hope they use the required
>> libraries when they build their packages.
>
> They'll have to now :-)

I'm pretty sure all the package building processes require that
already. E.g. if you're building packages for squeeze, you'll have the
-devel package from squeeze, etc.

I'm more curios as to what we're doing if the function isn't present.
What is it used for, and what will we do if it's not there? If we're
going to end up importing the same functionality directly into
pgadmin, we might as well use that one when we do..

Or do you mean a configure check that will refuse to build it if it's not there?

>
>> Really curious to see your patch. I've never had to change the configure
>> stuff. Yet another thing to learn :)
>
> http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff

Hmm, that answers my previous question.

This "disqualifies" pgAdmin3 from quite a lot of platforms. There
aren't that many that are on 8.4+ yet :-(

--
 Magnus Hagander
 Me: http://www.hagander.net/
 Work: http://www.redpill-linpro.com/

pgadmin-hackers by date:

Previous
From: Dave Page
Date:
Subject: Re: Issue with libpq < 8.4
Next
From: Dave Page
Date:
Subject: Re: Issue with libpq < 8.4