Re: multibyte charater set in levenshtein function - Mailing list pgsql-hackers

From Itagaki Takahiro
Subject Re: multibyte charater set in levenshtein function
Date
Msg-id AANLkTimUH_YIs-T_KlEJzoGJuImxh74bBgJH6WVpCRS9@mail.gmail.com
Whole thread Raw
In response to Re: multibyte charater set in levenshtein function  (Alexander Korotkov <aekorotkov@gmail.com>)
Responses Re: multibyte charater set in levenshtein function
List pgsql-hackers
2010/7/13 Alexander Korotkov <aekorotkov@gmail.com>:
> Anyway I think that overhead is not ignorable. That's why I have splited
> levenshtein_internal into levenshtein_internal and levenshtein_internal_mb,
> and levenshtein_less_equal_internal into levenshtein_less_equal_internal and
> levenshtein_less_equal_internal_mb.

Thank you for good measurement! Then, it's reasonable to have multiple
implementations. It also has documentation. I'll change status of the
patch to "Ready for Committer".

The patch is good enough except argument types for some functions.
For example: - char* vs. const char* - text* vs. const char* + length
I hope committers would check whether there are better types for them.

-- 
Itagaki Takahiro


pgsql-hackers by date:

Previous
From: Simon Riggs
Date:
Subject: Re: Explicit psqlrc
Next
From: Itagaki Takahiro
Date:
Subject: Re: (9.1) btree_gist support for searching on "not equals"