Re: Issues with two-server Synch Rep - Mailing list pgsql-hackers

From Greg Stark
Subject Re: Issues with two-server Synch Rep
Date
Msg-id AANLkTimKkOJYHakLDGp9qTFmLJtf1TQ8Ds6C2MTYDYjn@mail.gmail.com
Whole thread Raw
In response to Re: Issues with two-server Synch Rep  (Robert Haas <robertmhaas@gmail.com>)
Responses Re: Issues with two-server Synch Rep  (Robert Haas <robertmhaas@gmail.com>)
Re: Issues with two-server Synch Rep  (Peter Eisentraut <peter_e@gmx.net>)
List pgsql-hackers
On Mon, Oct 11, 2010 at 5:41 PM, Robert Haas <robertmhaas@gmail.com> wrote:
> That's probably not going to happen until we have a way to update
> postgresql.conf via SQL.  Which, I maintain, as I have maintained
> before, is not going to happen until we get rid of the comments,
> because otherwise absolutely any implementation anyone proposes will
> get criticized for failing to handle them sensibly (because it is not
> possible to rewrite the file while handling the comments sensibly).
>

So we've been over this. All the pieces you need are already there:
you can handle this without any nasty comment grunging by just writing
the new setting to a postgresql.auto and including that from
postgresql.conf. Include a note in postgresql.auto warning users any
changes in this file will be thrown away when the file is rewritten.
This is the same method used in .emacs.custom or a million other
places people wanted automatically written config files.

Also incidentally pgadmin currently *does* rewrite postgresql.conf
while keeping the comments. I think that's not such a hot idea because
it interferes with things like debian configuration file management
and so on, but it's not impossible to do. It's just that separating
automatically written files from user-editable files is a better
long-term plan.

--
greg


pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: Issues with two-server Synch Rep
Next
From: Robert Haas
Date:
Subject: Re: Issues with two-server Synch Rep