pgAdmin III: Error on clicking "Display Objects" while doing a restore - Mailing list pgadmin-hackers

From Nikhil S
Subject pgAdmin III: Error on clicking "Display Objects" while doing a restore
Date
Msg-id AANLkTimB6FvguVDUdAHE=mZqybECfWWi_BNaD+LGbM=x@mail.gmail.com
Whole thread Raw
Responses Re: pgAdmin III: Error on clicking "Display Objects" while doing a restore  (Guillaume Lelarge <guillaume@lelarge.info>)
List pgadmin-hackers
Hi,

The following set of operations induce an error:

1. Create a backup file /tmp/pg.backup of an existing database
2. Create a new database
3. Right click and select restore database by specifying this file
4. Clicking on "Display Objects" causes the following error: "An error has occurred: Schema node not found for object DATABASE postgres [ owner postgres ]

The frmRestore::OnEndProcess() function, when it reads the toc information, should ignore the line which contains the entry for the dumped database itself. So the current code erroneously tries to find the schema to which the DATABASE object belongs and gives out the above error. The fix is to ignore the input line which contains the db information. The pg_restore binary also seems to do the same.

PFA, patch to fix this.

Regards,
Nikhils
Attachment

pgadmin-hackers by date:

Previous
From: Dave Page
Date:
Subject: Re: pgAdmin III: crash when trying to save edited pg_hba.conf
Next
From: Dave Page
Date:
Subject: Re: wxWidgets 2.9 build