Re: I: About "Our CLUSTER implementation is pessimal" patch - Mailing list pgsql-hackers

From Itagaki Takahiro
Subject Re: I: About "Our CLUSTER implementation is pessimal" patch
Date
Msg-id AANLkTikxc-x3Zz+e4i_ufutbG+Z8nD_1Qa6+BJ5uqrQP@mail.gmail.com
Whole thread Raw
In response to Re: I: About "Our CLUSTER implementation is pessimal" patch  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
On Fri, Oct 8, 2010 at 10:49 AM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> Itagaki Takahiro <itagaki.takahiro@gmail.com> writes:
>> I wrote a patch to improve CLUSTER VERBOSE (and VACUUM FULL VERBOSE).
>> The patch should be applied after sorted_cluster-20100721.patch .
>
> Applied with minor fixes; in particular, I think you got the effects of
> rewrite_heap_dead_tuple backwards.  When a tuple is removed from
> unresolved_tups, that amounts to changing its status from "recently
> dead" to "dead and will not be written out".

Ah, yes. I misunderstood the behavior. Thanks for the fix!

--
Itagaki Takahiro


pgsql-hackers by date:

Previous
From: Heikki Linnakangas
Date:
Subject: Re: standby registration (was: is sync rep stalled?)
Next
From: Heikki Linnakangas
Date:
Subject: Re: standby registration (was: is sync rep stalled?)