Re: Re: [COMMITTERS] pgsql: Fix log_temp_files docs and comments to say bytes not kilobytes. - Mailing list pgsql-hackers

From Robert Haas
Subject Re: Re: [COMMITTERS] pgsql: Fix log_temp_files docs and comments to say bytes not kilobytes.
Date
Msg-id AANLkTiktpCf1QXBCwTUfoXYXokwUYf5Yx3FWaIVjTzLO@mail.gmail.com
Whole thread Raw
In response to Re: Re: [COMMITTERS] pgsql: Fix log_temp_files docs and comments to say bytes not kilobytes.  (Josh Berkus <josh@agliodbs.com>)
Responses Re: Re: [COMMITTERS] pgsql: Fix log_temp_files docs and comments to say bytes not kilobytes.
Re: Re: [COMMITTERS] pgsql: Fix log_temp_files docs and comments to say bytes not kilobytes.
List pgsql-hackers
On Fri, Jun 25, 2010 at 1:56 PM, Josh Berkus <josh@agliodbs.com> wrote:
>
>>> Shouldn't this be backpatched, or was this a new bug in 9.0?
>
> We've always output bytes.  I'd have noticed the discrepancy myself if I'd
> read the actual docs ;-)
>
> KB would be more useful.  And I don't think people have enough scripts built
> on this yet to make this break anything.  We should backport to 8.4.

log_temp_files was introduced in 8.3, so we'll need to backpatch this
to 8.3, not just 8.4.  Greg Smith tells me Simon has been busy with
other things, so I'm going to pick this up.  Barring objections, I'm
going to revert Simon's patch and change the behavior instead, per the
attached patch.  I will also back-patch the fix to 8.4 and 8.3.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise Postgres Company

Attachment

pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: t_self as system column
Next
From: Tom Lane
Date:
Subject: Re: Bug? Concurrent COMMENT ON and DROP object