Re: pgsql: Add DISCARD to the command_no_begin list for AUTOCOMMIT=off. - Mailing list pgsql-committers

From Itagaki Takahiro
Subject Re: pgsql: Add DISCARD to the command_no_begin list for AUTOCOMMIT=off.
Date
Msg-id AANLkTikqDgOYOOCz6hB88PBDMQ84nWUf8jDG27FTwFvE@mail.gmail.com
Whole thread Raw
In response to Re: pgsql: Add DISCARD to the command_no_begin list for AUTOCOMMIT=off.  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-committers
On Tue, Sep 28, 2010 at 3:36 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> Itagaki Takahiro <itagaki.takahiro@gmail.com> writes:
>> Add DISCARD to the command_no_begin list for AUTOCOMMIT=off.
>
> This patch appears incorrect to me.  Only the DISCARD ALL variant is
> prohibited inside BEGIN, so why is it making all variants of DISCARD
> autocommittable?
>
> The DROP coding immediately above is a model for how to deal with
> two-word commands.

Oops, thanks. I'll fix it.

--
Itagaki Takahiro

pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: Re: pgsql: Add DISCARD to the command_no_begin list for AUTOCOMMIT=off.
Next
From: Itagaki Takahiro
Date:
Subject: pgsql: Only DISCARD ALL should be in the command_no_begin list.