Postgres Pro
Downloads
Home   >   mailing lists

Re: pgsql: Add DISCARD to the command_no_begin list for AUTOCOMMIT=off. - Mailing list pgsql-committers

From Tom Lane
Subject Re: pgsql: Add DISCARD to the command_no_begin list for AUTOCOMMIT=off.
Date
Msg-id 17539.1285655784@sss.pgh.pa.us
Whole thread Raw
In response to pgsql: Add DISCARD to the command_no_begin list for AUTOCOMMIT=off.  (Itagaki Takahiro <itagaki.takahiro@gmail.com>)
Responses Re: pgsql: Add DISCARD to the command_no_begin list for AUTOCOMMIT=off.  (Itagaki Takahiro <itagaki.takahiro@gmail.com>)
List pgsql-committers
Tree view 
Itagaki Takahiro <itagaki.takahiro@gmail.com> writes:
> Add DISCARD to the command_no_begin list for AUTOCOMMIT=off.

This patch appears incorrect to me.  Only the DISCARD ALL variant is
prohibited inside BEGIN, so why is it making all variants of DISCARD
autocommittable?

The DROP coding immediately above is a model for how to deal with
two-word commands.

            regards, tom lane

pgsql-committers by date:

Previous
From: Itagaki Takahiro
Date:
Subject: pgsql: Add DISCARD to the command_no_begin list for AUTOCOMMIT=off.
Next
From: Itagaki Takahiro
Date:
Subject: Re: pgsql: Add DISCARD to the command_no_begin list for AUTOCOMMIT=off.