I think the patch is almost ready for committer except the following
three issues:
2010/7/13 Fujii Masao <masao.fujii@gmail.com>:
>> + if (!*value || *endptr || file_mode < 0 || file_mode > 0777)
> The sticky bit cannot be set via log_file_mode. Is this intentional?
We should also check the value not to be something like 0699.
How about checking it with (file_mode & ~0666) != 0 ?
>> +#ifndef WIN32
>> + chmod(filename, Log_file_mode);
>> +#endif
> Don't we need to check the return value of chmod()?
I prefer umask() rather than chmod() here.
>> +const char *show_log_file_mode(void);
> You forgot to write the show_log_file_mode()? I was not able to find that
> in the patch.
I want show_log_file_mode to print the setting value in octal format.
--
Itagaki Takahiro
