Re: gincostestimate - Mailing list pgsql-hackers

From Robert Haas
Subject Re: gincostestimate
Date
Msg-id AANLkTiki9N+7gASPdi78BGULYs4ZKJPHZMmj8NpPhMz4@mail.gmail.com
Whole thread Raw
In response to Re: gincostestimate  (Jan Urbański <wulczer@wulczer.org>)
List pgsql-hackers
On Fri, Jul 30, 2010 at 1:19 PM, Jan Urbański <wulczer@wulczer.org> wrote:
> The patch has lots of statements like if ( GinPageIsLeaf(page) ), that is
> with extra space between the outer parenthesis and the condition, which
> AFAIK is not the project style. I guess pgindent fixes that, so it's no big
> deal.

It's better if these get cleaned up.  pgindent will fix it eventually,
but the less stuff pgindent has to touch, the less likelihood there is
of breaking outstanding patches when it's run.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise Postgres Company


pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: reducing NUMERIC size for 9.1
Next
From: Tom Lane
Date:
Subject: Re: reducing NUMERIC size for 9.1