Re: patch (for 9.1) string functions - Mailing list pgsql-hackers

From Itagaki Takahiro
Subject Re: patch (for 9.1) string functions
Date
Msg-id AANLkTikdSujjNLfkH2AD8fyfV_ydeqoTHS9tPJYHLu2R@mail.gmail.com
Whole thread Raw
In response to Re: patch (for 9.1) string functions  (Pavel Stehule <pavel.stehule@gmail.com>)
Responses Re: patch (for 9.1) string functions
List pgsql-hackers
2010/7/21 Pavel Stehule <pavel.stehule@gmail.com>:
> It is about 2% slower for UTF8 encoding. So it isn't significant for me.
> I agree with your changes. Thank You very much

Thanks. The core-part is almost ready to commit.
I'll continue to review the contrib part.

But I found there is a design issue in format() :
Appending a '%' is common use-case, but format() cannot append
% char without any spaces between placeholder and the raw % char.

itagaki=# SELECT format('%%%', 10), format('% %%', 10);format | format
--------+--------%10    | 10 %
(1 row)

It is a design issue, and RAISE in PL/pgSQL has the same issue, too.
Do we accept the restriction? Or should we add another escape
syntax and/or placeholder pattern?

-- 
Itagaki Takahiro


pgsql-hackers by date:

Previous
From: Itagaki Takahiro
Date:
Subject: Re: SQL/MED security
Next
From: KaiGai Kohei
Date:
Subject: Re: Patch for 9.1: initdb -C option