Re: pg_dump --split patch - Mailing list pgsql-hackers

From David Wilson
Subject Re: pg_dump --split patch
Date
Msg-id AANLkTikZ4tJBSoa0QCmvgfCx6M6kfexvEZnKzg8b8QTq@mail.gmail.com
Whole thread Raw
In response to Re: pg_dump --split patch  (Joel Jacobson <joel@gluefinance.com>)
Responses Re: pg_dump --split patch
Re: pg_dump --split patch
List pgsql-hackers
On Tue, Dec 28, 2010 at 2:39 PM, Joel Jacobson <joel@gluefinance.com> wrote:

I think you are right about functions (and aggregates) being the only desc-type where two objects can share the same name in the same schema.
This means the problem of dumping objects in different order is a very limited problem, only affecting overloaded functions.

I didn't include the arguments in the file name, as it would lead to very long file names unless truncated, and since the problem is very limited, I think we shouldn't include it. It's cleaner with just the name part of the tag in the file name.

Why not place all overloads of a function within the same file? Then, assuming you order them deterministically within that file, we sidestep the file naming issue and maintain useful diff capabilities, since a diff of the function's file will show additions or removals of various overloaded versions.

--
- David T. Wilson
david.t.wilson@gmail.com

pgsql-hackers by date:

Previous
From: Karl Lehenbauer
Date:
Subject: Revised patches to add table function support to PL/Tcl (TODO item)
Next
From: Peter Geoghegan
Date:
Subject: Re: "writable CTEs"