Re: Add ENCODING option to COPY - Mailing list pgsql-hackers

From Hitoshi Harada
Subject Re: Add ENCODING option to COPY
Date
Msg-id AANLkTikXcZRx5uvSC+x_TJtrgjUbxxqF8w38kXofnEfC@mail.gmail.com
Whole thread Raw
In response to Re: Add ENCODING option to COPY  (Hitoshi Harada <umi.tanuki@gmail.com>)
Responses Re: Add ENCODING option to COPY  (Itagaki Takahiro <itagaki.takahiro@gmail.com>)
List pgsql-hackers
2011/2/1 Hitoshi Harada <umi.tanuki@gmail.com>:
> 2011/2/1 Tom Lane <tgl@sss.pgh.pa.us>:
>> Hitoshi Harada <umi.tanuki@gmail.com> writes:
>>> Finally I concluded the concern Itagaki-san raised can be solved by
>>> adding code that restores client_encoding in copy_in_error_callback.
>>
>> It might happen to work today (or at least in the scenarios you tested),
>> but it seems fragile as can be.
>
> Although I thought its fragile-ness was acceptable to avoid making the
> patch too complex, I agree with you.
> The third patch is attached, modifying mb routines so that they can
> receive conversion procedures as FmgrInof * and save the function
> pointer in CopyState.
> I tested it with encoding option and could not see performance slowdown.
>

Hmm, sorry, the patch was wrong. Correct version is attached.

Regards,



--
Hitoshi Harada

Attachment

pgsql-hackers by date:

Previous
From: Fujii Masao
Date:
Subject: Re: Allowing multiple concurrent base backups
Next
From: Pavel Stehule
Date:
Subject: Re: [pgsql-general 2011-1-21:] Are there any projects interested in object functionality? (+ rule bases)