Re: bug in SignalSomeChildren - Mailing list pgsql-hackers

From Robert Haas
Subject Re: bug in SignalSomeChildren
Date
Msg-id AANLkTikU-SfvkuW3XbD=zwmvGQ86jk7ezXpTOtuPfEMi@mail.gmail.com
Whole thread Raw
In response to Re: bug in SignalSomeChildren  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: bug in SignalSomeChildren  (Tom Lane <tgl@sss.pgh.pa.us>)
Re: bug in SignalSomeChildren  (Martijn van Oosterhout <kleptog@svana.org>)
List pgsql-hackers
On Mon, Dec 20, 2010 at 2:23 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> Robert Haas <robertmhaas@gmail.com> writes:
>> Another option that might be workable (but I have reservations, and
>> haven't tested it either) is to check whether the return value of
>> getppid() is equal to 1.  If it's neither 1 nor PostmasterPid then try
>> kill().
>
> I like that better actually ... one less thing for developers to get wrong.

The attached patch appears to work correctly on MacOS X.  I did check,
BTW: getppid() in the attached process returns gdb's pid.  Poor!

For my own purposes, I would be just as happy to apply this only to
master.  But I wonder if anyone wants to argue for back-patching, to
help debug existing installations?

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Attachment

pgsql-hackers by date:

Previous
From: Kenneth Marshall
Date:
Subject: Re: Extensions, patch v20 (bitrot fixes)
Next
From: "David E. Wheeler"
Date:
Subject: Re: Extensions, patch v20 (bitrot fixes)