Re: RecordTransactionCommit() and SharedInvalidationMessages - Mailing list pgsql-hackers

From Fujii Masao
Subject Re: RecordTransactionCommit() and SharedInvalidationMessages
Date
Msg-id AANLkTikTgdHw+rhVN9MaNjLcAy2MyaMM7n28842L64kR@mail.gmail.com
Whole thread Raw
In response to Re: RecordTransactionCommit() and SharedInvalidationMessages  (Robert Haas <robertmhaas@gmail.com>)
Responses Re: RecordTransactionCommit() and SharedInvalidationMessages
List pgsql-hackers
On Fri, Aug 13, 2010 at 10:24 AM, Robert Haas <robertmhaas@gmail.com> wrote:
> On Thu, Aug 12, 2010 at 12:11 AM, Fujii Masao <masao.fujii@gmail.com> wrote:
>>>>>> It appears to me that RecordTransactionCommit() only needs to WAL-log
>>>>>> shared invalidation messages when wal_level is hot_standby, but I
>>>>>> don't see a guard to prevent it from doing it in all cases.
> [...]
>>>> The fix looks pretty simple (see attached), although I don't have any
>>>> clear idea how to test it.
>>> Should use XLogStandbyInfoActive() macro, for the sake of consistency.
>> And, RelcacheInitFileInval should be initialized with false just in case.
>
> How about this?

Looks good to me.

Regards,

-- 
Fujii Masao
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center


pgsql-hackers by date:

Previous
From: Fujii Masao
Date:
Subject: Re: typos in HS source code comment
Next
From: Tom Lane
Date:
Subject: Re: Patch to show individual statement latencies in pgbench output