Re: Per-column collation - Mailing list pgsql-hackers

From Itagaki Takahiro
Subject Re: Per-column collation
Date
Msg-id AANLkTikHy6S6hTF1Yf1o+3igA2XV7E5y25fXzY-QUCC0@mail.gmail.com
Whole thread Raw
In response to Re: Per-column collation  (Greg Smith <greg@2ndquadrant.com>)
Responses Re: Per-column collation  (Greg Smith <greg@2ndquadrant.com>)
List pgsql-hackers
On Thu, Dec 16, 2010 at 19:37, Greg Smith <greg@2ndquadrant.com> wrote:
> I just updated the CF app to track Peter's latest update, which remains
> untested by anyone else for whether it fixes all the issues brought up.  It
> would be nice to get a re-review to confirm things are still working in
> advance of CF 2011-01.

Sorry, I don't have enough time to review it. Also, multiple reviewers
using different kinds of settings would be preferred for such feature.

# We might need "previous reviewers" and "active reviewers" in commit-fest
# app. Or, should non-active reviewers delete their names?

I tested it in program-level, but the code-level review is still needed.
I'm worried about whether "no holes" checks are required in COLLATE
hand-off from function to function. If so, the review will be a harder
work than the case where the framework guarantee the hand-off.

--
Itagaki Takahiro


pgsql-hackers by date:

Previous
From: Itagaki Takahiro
Date:
Subject: Re: Default mode for shutdown
Next
From: Greg Smith
Date:
Subject: Re: Per-column collation