Re: pgsql: Speed up conversion of signed integers to C strings. - Mailing list pgsql-committers

From Robert Haas
Subject Re: pgsql: Speed up conversion of signed integers to C strings.
Date
Msg-id AANLkTikFFW3iqzh_Hz1y7pGr1X+xUszYj55H_NULJF_2@mail.gmail.com
Whole thread Raw
In response to Re: pgsql: Speed up conversion of signed integers to C strings.  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: pgsql: Speed up conversion of signed integers to C strings.  (Andrew Dunstan <andrew@dunslane.net>)
List pgsql-committers
On Fri, Nov 19, 2010 at 11:47 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> I wrote:
>> Robert Haas <rhaas@postgresql.org> writes:
>>> Speed up conversion of signed integers to C strings.
>
>> This patch breaks the build here:
>
> ... and while I'm looking at it, the added int8 regression test cases
> definitely merit a WTF.  They aren't testing what I would expect.
> What they are testing is platform-specific behavior of excessive
> shifting, which is why some of the buildfarm members are pink.

Ugh.  I made an attempt at a fix to both of these issues, but I'm not
totally sure I got it right, and I'm too tired to stay up any later to
see what happens.  I'll check the BF in the morning.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

pgsql-committers by date:

Previous
From: Robert Haas
Date:
Subject: pgsql: Attempt to fix breakage caused by signed integer conversion patc
Next
From: Andrew Dunstan
Date:
Subject: Re: pgsql: Speed up conversion of signed integers to C strings.