On Sat, Jan 22, 2011 at 4:25 PM, Dimitri Fontaine
<dimitri@2ndquadrant.fr> wrote:
> Hi,
>
> This is a first level of review for the patch. I finally didn't get as
> much time as I hoped I would, so couldn't get familiar with the locking
> internals and machinery… as a result, I can't much comment on the code.
>
> The patch applies cleanly (patch moves one hunk all by itself) and
> compiles with no warning. It includes no docs, and I think it will be
> required to document the user visible SELECT … FOR KEY LOCK OF x new
> feature.
I feel like this should be called "KEY SHARE" rather than "KEY LOCK".
It's essentially a weaker version of the SHARE lock we have now, but
that's not clear from the name.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
