Re: string function - "format" function proposal - Mailing list pgsql-hackers

From Itagaki Takahiro
Subject Re: string function - "format" function proposal
Date
Msg-id AANLkTi=aOs9giSxax6sCZ-0597jDvEZk3q4PNhyVugdj@mail.gmail.com
Whole thread Raw
In response to Re: string function - "format" function proposal  (Pavel Stehule <pavel.stehule@gmail.com>)
Responses Re: string function - "format" function proposal  (Pavel Stehule <pavel.stehule@gmail.com>)
List pgsql-hackers
On Wed, Sep 1, 2010 at 1:29 PM, Pavel Stehule <pavel.stehule@gmail.com> wrote:
>> * %v also doesn't quote boolean values, but t and f are not valid.
>>  You should use true and false (or 't' and 'f') for the cases.
>
> you have a true - it should be fixed

I found quote_literal() prints boolean values as 'true' or 'false'.
It uses casting to text type rather than calling output function.
OTOH, format functions (and concat funcs) use output functions.

Which should we use for such purposes? Consistent behavior is
obviously preferred. Boolean type might be the only type that
is converted to different representation in typoutput or cast-to-test,
but we should consider to have boolean-specific hardwired code,
or cast all types to text instead of output functions.

--
Itagaki Takahiro


pgsql-hackers by date:

Previous
From: KaiGai Kohei
Date:
Subject: Re: leaky views, yet again
Next
From: Heikki Linnakangas
Date:
Subject: Re: Interruptible sleeps (was Re: CommitFest 2009-07: Yay, Kevin! Thanks, reviewers!)