Re: [pgadmin-hackers] Re: [pgadmin-hackers] Re: [pgadmin-hackers] error: expected initializer before ‘!’ token - Mailing list pgadmin-hackers

From Peter Geoghegan
Subject Re: [pgadmin-hackers] Re: [pgadmin-hackers] Re: [pgadmin-hackers] error: expected initializer before ‘!’ token
Date
Msg-id AANLkTi=XNPfpKuQWFVUUA0nCXDT4S8yPYuZd2fPtQDgB@mail.gmail.com
Whole thread Raw
In response to Re: [pgadmin-hackers] Re: [pgadmin-hackers] Re: [pgadmin-hackers] error: expected initializer before ‘!’ token  (Guillaume Lelarge <guillaume@lelarge.info>)
Responses Re: [pgadmin-hackers] Re: [pgadmin-hackers] Re: [pgadmin-hackers] error: expected initializer before ‘!’ token
List pgadmin-hackers
On 14 March 2011 20:22, Guillaume Lelarge <guillaume@lelarge.info> wrote:
> So I worked a bit on this issue tonight. I think you didn't allocate
> enough memory for filename. See the patch attached. With this patch, it
> works OK for me. I'm wondering if the patch should also do +1 on the
> other calloc calls. Any ideas on this?
>
> Can you check that it still works on Windows and Mac OS X with this patch?

This would of course explain the inconsistent behaviour across
platforms - it was undefined.

This is the the classic "strlen() doesn't include null terminated byte" mistake.


--
Peter Geoghegan       http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training and Services


pgadmin-hackers by date:

Previous
From: Guillaume Lelarge
Date:
Subject: Re: [pgadmin-hackers] Re: [pgadmin-hackers] Re: [pgadmin-hackers] error: expected initializer before ‘!’ token
Next
From: Dave Page
Date:
Subject: pgAdmin III commit: Fix the path to the image files, per Vladimir Kokov