Re: SQL command to edit postgresql.conf, with comments - Mailing list pgsql-hackers

From Robert Haas
Subject Re: SQL command to edit postgresql.conf, with comments
Date
Msg-id AANLkTi=WHcDHGYB=epeeXZGw8-rUSR=ODaLpudXdc7+q@mail.gmail.com
Whole thread Raw
In response to Re: SQL command to edit postgresql.conf, with comments  (Dimitri Fontaine <dimitri@2ndQuadrant.fr>)
Responses Re: SQL command to edit postgresql.conf, with comments
List pgsql-hackers
On Wed, Oct 13, 2010 at 3:41 AM, Dimitri Fontaine
<dimitri@2ndquadrant.fr> wrote:
> Tom Lane <tgl@sss.pgh.pa.us> writes:
>> I agree with Josh's proposal: keep mechanically-generated settings in a
>> separate file, and don't even pretend to allow comments to be kept there.
>
> And then, when you SET PERMANENT knob TO value (or whatever the syntax
> is), you never know what value is selected at next startup or SIGHUP.
>
> I know I'm alone on this, but I much prefer the all-machine-friendly
> proposal that still makes it possible to hand-edit the files.

You're not alone on this at all: I agree 100%.  I don't like your
proposed syntax, but I completely agree with your concern.  I don't
see what's wrong with having the initial contents of postgresql.conf
look like this (these are the settings that are uncommented by default
on my machine):

# type "man postgresql.conf" for help on editing this file
max_connections = 100
shared_buffers = 32MB
datestyle = 'iso, mdy'
lc_messages = 'en_US.UTF-8'
lc_monetary = 'en_US.UTF-8'
lc_numeric = 'en_US.UTF-8'
lc_time = 'en_US.UTF-8'
default_text_search_config = 'pg_catalog.english'

When you type 'man postgresql.conf' it can tell you all of the things
that are currently in the file as comments.  It's just that they'll be
in a man page rather in the file itself.  I don't see what's bad about
that.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


pgsql-hackers by date:

Previous
From: Jan Otto
Date:
Subject: Re: ISN patch that applies cleanly with git apply
Next
From: Tom Lane
Date:
Subject: Re: levenshtein_less_equal (was: multibyte charater set in levenshtein function)