On 19 January 2011 22:40, Dave Page <dpage@pgadmin.org> wrote:
>> I have attached a patch for your information. Obviously, I am not
>> asking you to commit it. Most warnings have been fixed - I didn't fix
>> one in gqbGridPanel::OnButtonUp(wxCommandEvent&) where I think we
>> downcast with a C style cast.
>
> Hmm, I didn't spot anything in there that looked horrendously
> objectional. The "foo.c_str()" -> "(const char *) foo" changes are
> somewhat ugly though
I agree, but that's the best we can do while targeting both 2.8 and
2.9. There's a similar situation with switch statements having to be
cast to integer types - when we stop supporting 2.8, we can remove the
casts and call GetValue() on the proxy object.
--
Regards,
Peter Geoghegan
