Re: READ ONLY fixes - Mailing list pgsql-hackers

From Robert Haas
Subject Re: READ ONLY fixes
Date
Msg-id AANLkTi=J+pGGwvrk496AAh_7PKx=JTOrnoJ=nmRWfKNz@mail.gmail.com
Whole thread Raw
In response to Re: READ ONLY fixes  (Jeff Janes <jeff.janes@gmail.com>)
Responses Re: READ ONLY fixes  ("Kevin Grittner" <Kevin.Grittner@wicourts.gov>)
List pgsql-hackers
On Sun, Jan 16, 2011 at 6:58 PM, Jeff Janes <jeff.janes@gmail.com> wrote:
> I found the following message somewhat confusing:
> ERROR:  read-only property must be set before any query

I think what we need here is two messages, this one and a similar one
that starts with "read-write property...".

> When a subtransaction has set the mode more stringent than the
> top-level transaction did, that setting is reversed when the
> subtransaction ends (whether by success or by rollback), which was
> discussed as the desired behavior.  But the included regression tests
> do not exercise that case by testing the case where a SAVEPOINT is
> either rolled back or released.  Should those tests be included?

+1.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: READ ONLY fixes
Next
From: Robert Haas
Date:
Subject: Re: Error code for "terminating connection due to conflict with recovery"