Re: [BUGS] rollback to savepoint leads to transaction already in progress - Mailing list pgsql-hackers

From Itagaki Takahiro
Subject Re: [BUGS] rollback to savepoint leads to transaction already in progress
Date
Msg-id AANLkTi=57XG-UX3ve3XOi_Mi62nQ3P+s_bbrQmwO1oMd@mail.gmail.com
Whole thread Raw
In response to Re: [BUGS] rollback to savepoint leads to transaction already in progress  (David Newall <postgresql@davidnewall.com>)
List pgsql-hackers
On Thu, Oct 14, 2010 at 3:52 PM, David Newall
<postgresql@davidnewall.com> wrote:
> This does seem to be an new bug in previously working code.  While any
> solution that fixes the problem is good, it might pay to look the code that
> worked before.  As reported, it worked for ecpg (PostgreSQL 8.3.8) 4.4.1.

It works on 8.3, but it's still broken. Here is the code in 8.3.
It ignores "ROLLBACK TO savepoint", but also ignores "ROLLBACK TRANSACTION".

----
if (strcmp(transaction, "commit") == 0 || strcmp(transaction, "rollback") == 0)  con->committed = true;
else  con->committed = false;
----

--
Itagaki Takahiro


pgsql-hackers by date:

Previous
From: Bruce Momjian
Date:
Subject: Re: [COMMITTERS] pgsql: Still more tweaking of git_changelog.
Next
From: Andrew Dunstan
Date:
Subject: Re: Why do we have a database specification in .pgpass?