> On 18 Feb 2025, at 00:51, Jacob Champion <jacob.champion@enterprisedb.com> wrote:
>
> On Mon, Feb 17, 2025 at 10:15 AM Jacob Champion
> <jacob.champion@enterprisedb.com> wrote:
>> It's been a little bit since I've re-run my
>> fuzzers, and a new Valgrind run would be a good idea, so I will just
>> keep throwing tests at it
>
> Fuzzers are happy so far.
>
> Valgrind did find something! A mistake I made during parameter
> discovery: setup_oauth_parameters() ensures that conn->oauth_issuer_id
> is always set using the "issuer" connection option, but during the
> second connection, I reassigned the pointer for it (and
> conn->oauth_discovery_uri) and leaked the previous allocations.
Nice.
> Reviews for the commit message:
All proposed changes applied.
The attached rebased has your 0002 fix as well as some minor tweaks like a few
small whitespace changes from a pgperltidy run and a copyright date fix which
still said 2024.
Unless something shows up I plan to commit this sometime tomorrow to allow it
ample time in the tree before the freeze.
--
Daniel Gustafsson
