Re: pg_receivexlog add synchronous mode - Mailing list pgsql-hackers

From
Subject Re: pg_receivexlog add synchronous mode
Date
Msg-id A9C510524E235E44AE909CD4027AE196BAAA06D800@MBX-MSG-SV03.msg.nttdata.co.jp
Whole thread Raw
In response to Re: pg_receivexlog add synchronous mode  (Fujii Masao <masao.fujii@gmail.com>)
Responses Re: pg_receivexlog add synchronous mode  (Fujii Masao <masao.fujii@gmail.com>)
List pgsql-hackers
> Thanks for the review!
> 
> +            if (secs <= 0)
> +                secs = 1;    /* Always sleep at least 1 sec */
> +
> +            sleeptime = secs * 1000 + usecs / 1000;
> 
> The above is the code which caused that problem. 'usecs' should have been
> reset to zero when 'secs' are rounded up to 1 second. But not. Attached
> is the updated version of the patch.
Thank you for the refactoring v2 patch.
I did a review of the patch. 

1. applied cleanly and compilation was without warnings and errors
2. all regress tests was passed ok
3. sleeptime is ok when the --status-intarvall is set to 1

Regards,

--
Furuya Osamu

pgsql-hackers by date:

Previous
From: Asif Naeem
Date:
Subject: Re: Extending MSVC scripts to support --with-extra-version
Next
From: Abhijit Menon-Sen
Date:
Subject: Re: Autonomous Transaction (WIP)