Re: pg_receivexlog add synchronous mode - Mailing list pgsql-hackers

From
Subject Re: pg_receivexlog add synchronous mode
Date
Msg-id A9C510524E235E44AE909CD4027AE196BAAA06D7FB@MBX-MSG-SV03.msg.nttdata.co.jp
Whole thread Raw
In response to Re: pg_receivexlog add synchronous mode  (Fujii Masao <masao.fujii@gmail.com>)
Responses Re: pg_receivexlog add synchronous mode  (Fujii Masao <masao.fujii@gmail.com>)
List pgsql-hackers
> The patch looks somewhat complicated and bugs can be easily introduced
> because it tries to not only add new feature but also reorganize the main
> loop in HandleCopyStream at the same time. To keep the patch simple, I'm
> thinking to firstly apply the attached patch which just refactors the
> main loop. Then we can apply the main patch, i.e., add new feature.
> Thought?
Thank you for the refactoring patch.
I did a review of the patch.
As a result, I found the calculation of sleeptime when the --status-intarvall is set to 1 was incorrect.

--status-intarvall 1 -->  sleeptime 1.9999 !?
--status-intarvall 2 -->  sleeptime 1.9999 OK
--status-intarvall 3 -->  sleeptime 2.9999 OK

Regards,

--
Furuya Osamu

pgsql-hackers by date:

Previous
From: Simon Riggs
Date:
Subject: Re: Allowing NOT IN to use ANTI joins
Next
From: Andres Freund
Date:
Subject: Re: better atomics - v0.5