Re: Bug in error reporting for multi-line JSON - Mailing list pgsql-bugs

From Daniel Gustafsson
Subject Re: Bug in error reporting for multi-line JSON
Date
Msg-id A999DFE1-BD97-4E93-9EBF-55B386974C90@yesql.se
Whole thread Raw
In response to RE: Bug in error reporting for multi-line JSON  ("tanghy.fnst@fujitsu.com" <tanghy.fnst@fujitsu.com>)
Responses Re: Bug in error reporting for multi-line JSON  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-bugs
> On 25 Aug 2021, at 10:22, tanghy.fnst@fujitsu.com wrote:
>
> On Tuesday, March 2, 2021 6:50 AM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> Daniel Gustafsson <daniel@yesql.se> writes:
>>> I'm changing the status of this patch to Ready for Committer.
>>
>> I reviewed this and pushed it, with some changes.
>
> I think the while condition "context_start < context_end" added in commit ffd3944ab9 is useless. Thoughts?
>
> code added in ffd3944ab9
> + while (context_end - context_start >= 50 && context_start < context_end)

Judging by the diff it’s likely a leftover from the previous coding.  I don’t
see a case for when it would hit, but it also doesn’t seem to do any harm apart
from potentially causing static analyzers to get angry.

--
Daniel Gustafsson        https://vmware.com/




pgsql-bugs by date:

Previous
From: "tanghy.fnst@fujitsu.com"
Date:
Subject: RE: Bug in error reporting for multi-line JSON
Next
From: Neil Chen
Date:
Subject: Re: BUG #17157: authorizaiton of dict_int and bloom extention