Re: Autovacuum on partitioned table (autoanalyze) - Mailing list pgsql-hackers

From Daniel Gustafsson
Subject Re: Autovacuum on partitioned table (autoanalyze)
Date
Msg-id A7A3BAC3-4540-4946-8DAE-1D48370E2849@yesql.se
Whole thread Raw
In response to Re: Autovacuum on partitioned table (autoanalyze)  (yuzuko <yuzukohosoya@gmail.com>)
Responses Re: Autovacuum on partitioned table (autoanalyze)  (yuzuko <yuzukohosoya@gmail.com>)
List pgsql-hackers
> On 6 Jul 2020, at 12:35, yuzuko <yuzukohosoya@gmail.com> wrote:
>
>> On Wed, Jul 1, 2020 at 6:26 PM Daniel Gustafsson <daniel@yesql.se> wrote:
>>
>>> On 21 Apr 2020, at 18:21, yuzuko <yuzukohosoya@gmail.com> wrote:
>>
>>> I'll update the patch soon.
>>
>> Do you have an updated version to submit?  The previous patch no longer applies
>> to HEAD, so I'm marking this entry Waiting on Author in the meantime.
>>
> Thank you for letting me know.
> I attach the latest patch applies to HEAD.

This version seems to fail under Werror which is used in the Travis builds:

autovacuum.c: In function ‘relation_needs_vacanalyze’:
autovacuum.c:3117:59: error: ‘reltuples’ may be used uninitialized in this function [-Werror=maybe-uninitialized]
   anlthresh = (float4) anl_base_thresh + anl_scale_factor * reltuples;
                                                           ^
autovacuum.c:2972:9: note: ‘reltuples’ was declared here
  float4  reltuples;  /* pg_class.reltuples */
         ^

I've moved this patch to the next commitfest, but kept the status as Waiting on
Author.  Please submit a new version of the patch.

cheers ./daniel


pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: psql - improve test coverage from 41% to 88%
Next
From: Daniel Gustafsson
Date:
Subject: Re: Default gucs for EXPLAIN