Home > mailing lists

Re: CREATE INDEX CONCURRENTLY does not index prepared xact's data - Mailing list pgsql-bugs

From	Andrey Borodin
Subject	Re: CREATE INDEX CONCURRENTLY does not index prepared xact's data
Date	July 18, 2021 08:17:28
Msg-id	A74C56AE-FA8A-4BBD-8941-06AA8FED73E1@yandex-team.ru Whole thread Raw
In response to	Re: CREATE INDEX CONCURRENTLY does not index prepared xact's data (Tom Lane <tgl@sss.pgh.pa.us>)
List	pgsql-bugs

Tree view


> 18 июля 2021 г., в 01:12, Noah Misch <noah@leadboat.com> написал(а):
>
> Suppose some transaction has a vxid but no xid.  Shortly after
> GetLockConflicts(), it acquires an xid, modifies the table, and issues PREPARE
> TRANSACTION.  Could that cause a corrupt index even with this diff?

Firstly I've tried to stress things out. This little go program [0] easily reproduces corruption on patched code.
Meanwhile vxid->xid->2px program does not [1] (both patched and unpatched).

I think CIC does not care much about VXIDs at all. It's only important when real XID started: before GetLockConflicts()
orafter. 

Thanks!


Best regards, Andrey Borodin.

[0] https://gist.github.com/x4m/8b6025995eedf29bf588727375014dfc#file-stress-xid-2px
[1] https://gist.github.com/x4m/8b6025995eedf29bf588727375014dfc#file-stress-vxid-xid-2px

pgsql-bugs by date:

From: Thomas Munro
Date: 18 July 2021, 08:13:50
Subject: Re: BUG #16696: Backend crash in llvmjit

From: Pawel Kudzia
Date: 18 July 2021, 11:27:32
Subject: Re: IRe: BUG #16792: silent corruption of GIN index resulting in SELECTs returning non-matching rows

Re: CREATE INDEX CONCURRENTLY does not index prepared xact's data - Mailing list pgsql-bugs

Previous

Next