Re: PoC Refactor AM analyse API - Mailing list pgsql-hackers

From Denis Smirnov
Subject Re: PoC Refactor AM analyse API
Date
Msg-id A678F81D-6466-42DD-9021-961E3BA79054@arenadata.io
Whole thread Raw
In response to Re: PoC Refactor AM analyse API  (Andrey Borodin <x4mmm@yandex-team.ru>)
Responses Re: PoC Refactor AM analyse API
List pgsql-hackers
> But why do you pass int natts and VacAttrStats **stats to acquire_sample_rows()? Is it of any use? It seems to break
abstractiontoo. 

Yes, it is really a kluge that should be discussed. The main problem is that we don’t pass projection information to
analyzescan (analyze begin scan relise only on relation information during initialization). And as a result we can’t
benefitfrom column AMs during «analyze t(col)» and consume data only from target columns. This parameters were added to
solvethis problem. 

Best regards,
Denis Smirnov | Developer
sd@arenadata.io
Arenadata | Godovikova 9-17, Moscow 129085 Russia




pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: [PATCH] Simplify permission checking logic in user.c
Next
From: Dilip Kumar
Date:
Subject: Re: Parallel Inserts in CREATE TABLE AS