Re: Reducing connection overhead in pg_upgrade compat check phase - Mailing list pgsql-hackers

From Daniel Gustafsson
Subject Re: Reducing connection overhead in pg_upgrade compat check phase
Date
Msg-id A3FD601F-18AD-4933-8DB6-9D150EC663A4@yesql.se
Whole thread Raw
In response to Re: Reducing connection overhead in pg_upgrade compat check phase  (Daniel Gustafsson <daniel@yesql.se>)
Responses Re: Reducing connection overhead in pg_upgrade compat check phase
List pgsql-hackers
> On 9 Feb 2024, at 00:04, Daniel Gustafsson <daniel@yesql.se> wrote:
>
>> On 8 Feb 2024, at 15:16, Daniel Gustafsson <daniel@yesql.se> wrote:
>
>> One option could perhaps be to include a version number for <= comparison, and
>> if set to zero a function pointer to a version check function must be provided?
>> That would handle the simple cases in a single place without messy logic, and
>> leave the more convoluted checks with a special case function.
>
> The attached is a draft version of this approach, each check can define to run
> for all versions, set a threshold version for which it runs or define a
> callback which implements a more complicated check.

And again pgindented and with documentation on the struct members to make it
easy to add new checks.  A repetitive part of the report text was also moved to
a single place.

--
Daniel Gustafsson


Attachment

pgsql-hackers by date:

Previous
From: Maiquel Grassi
Date:
Subject: RE: Psql meta-command conninfo+
Next
From: Maiquel Grassi
Date:
Subject: RE: Psql meta-command conninfo+