Re: Call lazy_check_wraparound_failsafe earlier for parallel vacuum - Mailing list pgsql-hackers

From Imseih (AWS), Sami
Subject Re: Call lazy_check_wraparound_failsafe earlier for parallel vacuum
Date
Msg-id A3F39AA3-A509-4EEF-BEFC-467DB3BA1246@amazon.com
Whole thread Raw
In response to Re: Call lazy_check_wraparound_failsafe earlier for parallel vacuum  (Peter Geoghegan <pg@bowt.ie>)
List pgsql-hackers
>    I adjusted the FAILSAFE_EVERY_PAGES comments, which now point out that
>    FAILSAFE_EVERY_PAGES is a power-of-two. The implication is that the
>    compiler is all but guaranteed to be able to reduce the modulo
>    division into a shift in the lazy_scan_heap loop, at the point of the
>    failsafe check. I doubt that it would really matter if the compiler
>    had to generate a DIV instruction, but it seems like a good idea to
>    avoid it on general principle, at least in performance sensitive code.

Thank you! 

Regards,

Sami Imseih
Amazon Web Services (AWS)


pgsql-hackers by date:

Previous
From: David Rowley
Date:
Subject: Re: Allow WindowFuncs prosupport function to use more optimal WindowClause options
Next
From: Michael Paquier
Date:
Subject: Re: Add LSN along with offset to error messages reported for WAL file read/write/validate header failures