Re: Bug in walsender when calling out to do_pg_stop_backup (and others?) - Mailing list pgsql-hackers

From Greg Jaskiewicz
Subject Re: Bug in walsender when calling out to do_pg_stop_backup (and others?)
Date
Msg-id A3D26723-F4A9-40AA-8E6A-F630B208BEF8@pointblue.com.pl
Whole thread Raw
In response to Re: Bug in walsender when calling out to do_pg_stop_backup (and others?)  (Florian Pflug <fgp@phlo.org>)
List pgsql-hackers
On 15 Oct 2011, at 11:31, Florian Pflug wrote:
>
> Ok, here's a first cut.

So I looked at the patch, and first thing that pops out,
is lack of the volatile keyword before the ClientConnectionLostPending variable is defined. Is that done on purpose ?
Isthat on purpose ? 


Otherwise the patch itself looks ok.
I haven't tested the code, just reviewed the patch itself. And it obviously needs testing, should be easy to follow
youroriginal problem description.  


Btw, I just tried to do it through commitfest.postgresql.org , but before I get my head around on how to add myself to
thereviewer list there - I thought I'll just send this response here. 



pgsql-hackers by date:

Previous
From: Florian Pflug
Date:
Subject: Re: Bug in walsender when calling out to do_pg_stop_backup (and others?)
Next
From: Robert Haas
Date:
Subject: Re: [PATCH] Log crashed backend's query v3