Re: Online enabling of checksums - Mailing list pgsql-hackers

From Andrey Borodin
Subject Re: Online enabling of checksums
Date
Msg-id A3C00ECF-BA87-4393-A519-3252495B932C@yandex-team.ru
Whole thread Raw
In response to Re: Online enabling of checksums  (Tomas Vondra <tomas.vondra@2ndquadrant.com>)
Responses Re: Online enabling of checksums
List pgsql-hackers

> 5 апр. 2018 г., в 14:33, Tomas Vondra <tomas.vondra@2ndquadrant.com> написал(а):
>
> This patch version seems fine to me. I'm inclined to mark it RFC.
+1
The patch works fine for me. I've tried different combinations of backend cancelation and the only suspicious thing I
foundis that you can start multiple workers by cancelling launcher and not cancelling worker. Is it problematic
behavior?If we run pg_enable_data_checksums() it checks for existing launcher for a reason, m.b. it should check for
workertoo? 

I think it worth to capitalize WAL in "re-write the page to wal".

Best regards, Andrey Borodin.

pgsql-hackers by date:

Previous
From: Nikhil Sontakke
Date:
Subject: Re: [HACKERS] logical decoding of two-phase transactions
Next
From: Magnus Hagander
Date:
Subject: Re: Online enabling of checksums