Re: Typo in tablesync comment - Mailing list pgsql-hackers

From Euler Taveira
Subject Re: Typo in tablesync comment
Date
Msg-id 9f7e3001-7154-4b71-b78e-5512fc8c79ab@www.fastmail.com
Whole thread Raw
In response to Re: Typo in tablesync comment  (Michael Paquier <michael@paquier.xyz>)
List pgsql-hackers
On Tue, Feb 2, 2021, at 2:19 AM, Michael Paquier wrote:
On Tue, Feb 02, 2021 at 10:38:31AM +1100, Peter Smith wrote:
> PSA a trivial patch to correct what seems like a typo in the tablesync comment.

- *       subscribed tables and their state.  Some transient state during data
- *       synchronization is kept in shared memory.  The states SYNCWAIT and
+ *       subscribed tables and their state.  Some transient states during data
+ *       synchronization are kept in shared memory. The states SYNCWAIT and

This stuff refers to SUBREL_STATE_* in pg_subscription_rel.h, and FWIW
I find confusing the term "transient" in this context as a state may
last for a rather long time, depending on the time it takes to
synchronize the relation, no?  I am wondering if we could do better
here, say:
"The state tracking the progress of the relation synchronization is
additionally stored in shared memory, with SYNCWAIT and CATCHUP only
appearing in memory."
WFM.


--
Euler Taveira

pgsql-hackers by date:

Previous
From: japin
Date:
Subject: Re: row filtering for logical replication
Next
From: "Euler Taveira"
Date:
Subject: Re: [PATCH] Doc: improve documentation of oid columns that can be zero. (correct version)