Re: dblink module printing unnamed connection (with commitacaf7ccb94) - Mailing list pgsql-hackers

From Peter Eisentraut
Subject Re: dblink module printing unnamed connection (with commitacaf7ccb94)
Date
Msg-id 9be723cc-f391-4d12-179a-3374f507b800@2ndquadrant.com
Whole thread Raw
In response to [HACKERS] dblink module printing unnamed connection (with commit acaf7ccb94)  (Rushabh Lathia <rushabh.lathia@gmail.com>)
List pgsql-hackers
On 3/23/17 01:38, Rushabh Lathia wrote:
> DBLINK contrib module started showing :"unnamed" connection name.

> Before this, macro used to assign the conname local variable; I quickly
> worked
> on the fix and attached patch do fix the issues. Patch assign the conname
> local variable, so that error context show the correct connection name.

Committed, thanks.

In dblink_record_internal(), I moved the conname =
text_to_cstring(PG_GETARG_TEXT_PP(0)) call a little bit, because it does
not apply in all code paths, so it could be a problem if you try to read
a text argument that the function is not actually passing in.

-- 
Peter Eisentraut              http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services



pgsql-hackers by date:

Previous
From: Alvaro Herrera
Date:
Subject: Re: Valgrind failures caused by multivariate stats patch
Next
From: Andres Freund
Date:
Subject: Re: Logical decoding on standby