Re: pgsql: Improve error messages for incorrect types of logicalreplicatio - Mailing list pgsql-committers

On 2019-01-13 08:45, Michael Paquier wrote:
> Improve error messages for incorrect types of logical replication 
> targets
> 
> Discussion:
> https://postgr.es/m/41799bee-40eb-7bb5-80b1-325ce17518bc@lab.ntt.co.jp
> 
> master
> https://git.postgresql.org/pg/commitdiff/373bda61d2d620e704815553978726c9be9e1209
> 
> Modified Files
> --------------
> src/backend/executor/execReplication.c | 22 ++++++++++++++++++++--

Good idea, but now one message (for RELKIND_FOREIGN_TABLE) omits 
'target'.

So I think
   errmsg("cannot use relation \"%s.%s\" as logical replication"

should be:
   errmsg("cannot use relation \"%s.%s\" as logical replication target"

Do you agree?


Thanks,


Erik Rijkers