Hi Greg,
I was able to successfully execute all the tests of the v17-0001 patch.
But I do have a couple of additional review comments about the test code.
====
COMMENT - missing "any" tests
In my earlier code review (previous email) I suggested that "any" should be added as valid option to the
target_server_typeparameter.
But this now means there are some missing test cases for
target_server_type = "any"
====
COMMENT - negative tests?
IIUC when "standby" (aka "secondary") is specified, and there is no in_recovery server available, then the result
shouldbe an error like "could not make a readonly connection to server "
But I did not find any such error combination tests.
e.g. Where are these test cases?
target_session_attrs = "standby", when no standby is available
target_session_attrs = "secondary", when no standby is available
target_server_type = "standby", when no standby is available
target_server_type = "secondary", when no standby is available
--
And, similarly for "could not make a writable connection to server ".
e.g. Where are these test cases?
target_session_attrs = "primary", when no primary is available
target_session_attrs = "read-write", when no primary is available
target_server_type = "primary", when no primary is available
target_server_type = "read-write", when no primary is available
Kind Regards,
Peter Smith
---
Fujitsu Australia