Re: New gist vacuum. - Mailing list pgsql-hackers

15 янв. 2018 г., в 23:34, Alexander Korotkov <a.korotkov@postgrespro.ru> написал(а):

I do not know, should I register separate commitfest entry? The code is very close to main GiST VACUUM patch, but solves a bit different problem.

Yes, I think it deserves separate commitfest entry.  Despite it's related to GiST VACUUM, it's a separate fix.

I've made small improvements to this patch: variable naming, formatting, comments.

BTW, do we really need to set shouldCount depending on whether we receive stats argument or not?  What if we always set shouldCount as in the first branch of "if"?

 

shouldCount = !heap_attisnull(rel->rd_indextuple, Anum_pg_index_indpred) ||
   info->estimated_count;