Re: refactoring basebackup.c - Mailing list pgsql-hackers

From Mark Dilger
Subject Re: refactoring basebackup.c
Date
Msg-id 9EFB22B8-28DC-4C44-866E-B45F5E526C34@enterprisedb.com
Whole thread Raw
In response to Re: refactoring basebackup.c  (Robert Haas <robertmhaas@gmail.com>)
Responses Re: refactoring basebackup.c  (Robert Haas <robertmhaas@gmail.com>)
List pgsql-hackers

> On Jul 20, 2021, at 11:57 AM, Robert Haas <robertmhaas@gmail.com> wrote:
>
> I don't really understand what your problem is with how the patch set
> leaves pg_basebackup.

I don't have a problem with how the patch set leaves pg_basebackup.

> On the server side, because I dropped the
> bbarchiver stuff, basebackup.c still ends up knowing a bunch of stuff
> about tar. pg_basebackup.c, however, really doesn't know anything much
> about tar any more. It knows that if it's getting a tar file and needs
> to parse a tar file then it had better call the tar parsing code, but
> that seems difficult to avoid.

I was only imagining having a callback for injecting manifests or recovery configurations.  It is not necessary that
thisbe done in the current patch set, or perhaps ever. 

—
Mark Dilger
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company






pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: [PATCH] Automatic HASH and LIST partition creation
Next
From: Filip Gospodinov
Date:
Subject: Re: Fix pkg-config file for static linking