> On 11 Jul 2024, at 23:16, Peter Eisentraut <peter@eisentraut.org> wrote:
> It would be worth checking the discussion at
<https://www.postgresql.org/message-id/flat/79692bf9-17d3-41e6-b9c9-fc8c3944222a@eisentraut.org>about
strtok()/strtok_r()issues. First, for list parsing, it sometimes gives the wrong semantics, which I think might apply
here. Maybe it's worth comparing this with the semantics that OpenSSL provides natively. And second, strtok_r() is not
availableon Windows without the workaround provided in that thread.
>
> I'm doubtful that it's worth replicating all this list parsing logic instead of just letting OpenSSL do it. This is
avery marginal feature after all.
The original author added the string parsing in order to provide a good error
message in case of an error in the list, and since that seemed like a nice idea
I kept in my review revision. With what you said above I agree it's not worth
the extra complexity it brings so the attached revision removes it.
--
Daniel Gustafsson
