Patch: Perl xsubpp - Mailing list pgsql-hackers

From David E. Wheeler
Subject Patch: Perl xsubpp
Date
Msg-id 9B946296-A2EB-4B45-A190-153F06662F8B@kineticode.com
Whole thread Raw
Responses Re: Patch: Perl xsubpp
List pgsql-hackers
Hackers,

Since installing Perl 5.14.1, I installed newer version of ExtUtils::ParseXS from CPAN. I installed it with `make
installUNINST=1`, which removes the copy of xsubpp that ships with core Perl. This results in an error during
PostgreSQL`make`: 

make -C plperl install
gcc -O2 -Wall -Wmissing-prototypes -Wpointer-arith -Wdeclaration-after-statement -Wendif-labels -Wformat-security
-fno-strict-aliasing-fwrapv  -I. -I. -I../../../src/include -I/usr/local/include/libxml2  -I/usr/local/include
-I/usr/local/lib/perl5/5.14.1/darwin-thread-multi-2level/CORE -c -o plperl.o plperl.c 
'/usr/local/bin/perl' /usr/local/lib/perl5/5.14.1/ExtUtils/xsubpp -typemap /usr/local/lib/perl5/5.14.1/ExtUtils/typemap
SPI.xs>SPI.c 
Can't open perl script "/usr/local/lib/perl5/5.14.1/ExtUtils/xsubpp": No such file or directory

I [asked][] Perl 5 Porters for the proper way to find xsubpp, and was [told][] that it was probably best to look in
@Config{qw(installsitebininstallvendorbin installbin)}. 

[asked]: http://www.xray.mpe.mpg.de/mailing-lists/perl5-porters/2011-09/msg00501.html
[told]: http://www.xray.mpe.mpg.de/mailing-lists/perl5-porters/2011-09/msg00686.html

The attached patch makes this change. I've tested it on Mac OS X and it works fine. Someone else will have to test it
onWindows. 

Best,

David

Attachment

pgsql-hackers by date:

Previous
From: Amit Kapila
Date:
Subject: Initialization of ResultTupleSlot in AppendNode
Next
From: Jesper Krogh
Date:
Subject: ginfastupdate.. slow