Re: Reworks of CustomScan serialization/deserialization - Mailing list pgsql-hackers

From Kouhei Kaigai
Subject Re: Reworks of CustomScan serialization/deserialization
Date
Msg-id 9A28C8860F777E439AA12E8AEA7694F8011CAEAE@BPXM15GP.gisp.nec.co.jp
Whole thread Raw
In response to Reworks of CustomScan serialization/deserialization  (Kouhei Kaigai <kaigai@ak.jp.nec.com>)
List pgsql-hackers
> On Sun, Mar 13, 2016 at 9:53 PM, Kouhei Kaigai <kaigai@ak.jp.nec.com> wrote:
> > OK, I split the previous small patch into two tiny patches.
> > The one is bugfix around max length of the extnodename.
> > The other replaces Assert() by ereport() according to the upthread discussion.
> 
> Committed, except that (1) I replaced ereport() with elog(), because I
> can't see making translators care about this message; and (2) I
> reworded the error message a bit.
>
Thanks, and I got the point why ereport() is suggested for the error
message that may be visible to users, instead of elog().

--
NEC Business Creation Division / PG-Strom Project
KaiGai Kohei <kaigai@ak.jp.nec.com>


pgsql-hackers by date:

Previous
From: David Rowley
Date:
Subject: Re: Parallel Aggregate
Next
From: Kouhei Kaigai
Date:
Subject: Re: WIP: Upper planner pathification