Re: --enable-odbc issue for Darwin/Mac OS X - Mailing list pgsql-patches

From Tom Lane
Subject Re: --enable-odbc issue for Darwin/Mac OS X
Date
Msg-id 9956.977105134@sss.pgh.pa.us
Whole thread Raw
In response to --enable-odbc issue for Darwin/Mac OS X  (Ronald Guest <ronald@pepsan.com>)
Responses Re: --enable-odbc issue for Darwin/Mac OS X  (Peter Eisentraut <peter_e@gmx.net>)
List pgsql-patches
Ronald Guest <ronald@pepsan.com> writes:
> /* Ignore malloc.h if we have STDC_HEADERS */
> #if defined(HAVE_MALLOC_H) && !defined(STDC_HEADERS)
> #       include <malloc.h>
> #endif

I'd vote for ripping those includes out altogether.  No other part of
our sources needs <malloc.h>, and I don't believe ODBC does or should
either.

In a larger sense, the ODBC driver is probably not nearly as portable
as the rest of Postgres, because it hasn't gotten wrung out on as many
platforms.  Maybe we ought to start compiling it by default (not for
7.1 though ;-)).

            regards, tom lane

pgsql-patches by date:

Previous
From: Ronald Guest
Date:
Subject: --enable-odbc issue for Darwin/Mac OS X
Next
From: Michael Davis
Date:
Subject: Bug fix