Re: [BUG] Logical replica crash if there was an error in a function. - Mailing list pgsql-hackers

From Tom Lane
Subject Re: [BUG] Logical replica crash if there was an error in a function.
Date
Msg-id 992334.1668477582@sss.pgh.pa.us
Whole thread Raw
In response to Re: [BUG] Logical replica crash if there was an error in a function.  ("Anton A. Melnikov" <aamelnikov@inbox.ru>)
Responses Re: [BUG] Logical replica crash if there was an error in a function.
List pgsql-hackers
"Anton A. Melnikov" <aamelnikov@inbox.ru> writes:
> On 02.11.2022 21:02, Tom Lane wrote:
>> I don't think the cost of that test case is justified by the tiny
>> probability that it'd ever catch anything.

> Seems it is possible to do a test without these remarks. The attached
> test uses existing nodes and checks the specific error message.

My opinion remains unchanged: this would be a very poor use of test
cycles.

> Additionally
> i've tried to reduce overall number of nodes previously
> used in this test in a similar way.

Optimizing existing tests isn't an answer to that.  We could
install those optimizations without adding a new test case.

            regards, tom lane



pgsql-hackers by date:

Previous
From: "Anton A. Melnikov"
Date:
Subject: Re: [BUG] Logical replica crash if there was an error in a function.
Next
From: Amit Langote
Date:
Subject: Re: List of Bitmapset (was Re: ExecRTCheckPerms() and many prunable partitions)