Manfred Koizar <mkoi-pg@aon.at> writes:
> Here is my proposal for omitting the oid, when it is not needed:
I do not think you can make this work unless "has oids" is added to
TupleDescs. There are too many places where tuples are manipulated
with only a tupdesc for reference.
It might also be necessary to add a "has oid" bit to t_infomask,
so that a tuple's OID can be fetched with *no* outside information,
but I'd prefer to avoid that if possible. I think adding a tupledesc
parameter to heap_getsysattr might be enough to avoid it.
I'd suggest reworking your "Wrap access to Oid" patch, which currently
increases instead of reducing the dependency on access to a Relation
for the tuple. Also, you could be a little more conservative about
adding Asserts --- those are not free, at least not from a development
point of view, so I object to adding multiple redundant Asserts in
hotspot routines.
regards, tom lane
