RE: Determine parallel-safety of partition relations for Inserts - Mailing list pgsql-hackers

Hi,

I notice the comment 5) about is_parallel_possible_for_modify() seems to be inaccurate in clauses.c.
    *  5) the reloption parallel_dml_enabled is not set for the target table

Because you have set parallel_dml_enabled to 'true' as default. 
    {
        {
            "parallel_dml_enabled",
            "Enables \"parallel dml\" feature for this table",
            RELOPT_KIND_HEAP | RELOPT_KIND_PARTITIONED,
            ShareUpdateExclusiveLock
        },
        true
    }

So even user doesn't set parallel_dml_enabled explicit, its value is 'on', Parallel is also possible for this rel(when
enable_parallel_dmlis on). 
 

Maybe we can just comment like this or a better one you'd like if you agree with above:
    *  5) the reloption parallel_dml_enabled is set to off

Regards
Huang

> -----Original Message-----
> From: Hou, Zhijie <houzj.fnst@cn.fujitsu.com>
> Sent: Wednesday, February 3, 2021 9:01 AM
> To: Greg Nancarrow <gregn4422@gmail.com>
> Cc: Amit Kapila <amit.kapila16@gmail.com>; PostgreSQL Hackers
> <pgsql-hackers@lists.postgresql.org>; vignesh C <vignesh21@gmail.com>;
> Amit Langote <amitlangote09@gmail.com>; David Rowley
> <dgrowleyml@gmail.com>; Tom Lane <tgl@sss.pgh.pa.us>; Tsunakawa,
> Takayuki/綱川 貴之 <tsunakawa.takay@fujitsu.com>
> Subject: RE: Determine parallel-safety of partition relations for Inserts
> 
> Hi,
> 
> Attaching v5 patches with the changes:
>   * rebase the code on the greg's latest parallel insert patch
>   * fix some code style.
> 
> Please consider it for further review.
> 
> Best regards,
> Houzj
> 
> 
> 
>